Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update netlify packages #6244

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 5, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@netlify/build (source) 29.29.4 -> 29.31.0 age adoption passing confidence
@netlify/build-info (source) 7.11.1 -> 7.11.3 age adoption passing confidence

Release Notes

netlify/build (@​netlify/build)

v29.31.0

Compare Source

Features
  • change blob store location from publish directory to .netlify folder (#​5432) (b83d83a)

v29.30.0

Compare Source

Features
netlify/build (@​netlify/build-info)

v7.11.3

Compare Source

Bug Fixes

v7.11.2

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner December 5, 2023 15:27
@renovate renovate bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 5, 2023
@renovate renovate bot enabled auto-merge (squash) December 5, 2023 15:27
Copy link

github-actions bot commented Dec 5, 2023

📊 Benchmark results

Comparing with db852be

  • Dependency count: 1,399 (no change)
  • Package size: 405 MB ⬆️ 0.02% increase vs. db852be
  • Number of ts-expect-error directives: 1,331 (no change)

kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 5, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
@Skn0tt
Copy link
Contributor

Skn0tt commented Dec 6, 2023

dd8c64d contained some non-trivial changes to our edge functions detection logic. This PR is currently holding up releases of build, so I won't wait for a review on this - as long as tests are passing, we should be good. I'll mark some people for a post-merge review.

kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
@Skn0tt
Copy link
Contributor

Skn0tt commented Dec 6, 2023

oh no, it force-pushed over my commits!

@Skn0tt
Copy link
Contributor

Skn0tt commented Dec 6, 2023

For the sake of unblocking releases, i'm going to disable the failing tests, and work on fixes in separate PRs

@lukasholzer
Copy link
Collaborator

@Skn0tt what does that mean? can we merge this PR or not? I need the build version to go through

@Skn0tt
Copy link
Contributor

Skn0tt commented Dec 6, 2023

In netlify/build#5421, we've started clearing the .netlify/functions-internal and .netlify/edge-functions directories before local dev. This makes sense in the case of framework-generated functions, but for our test fixtures it means that part of the fixture gets deleted :/ So the tests start failing.

We can merge this + release it, but we need to get the tests fixed.

kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
Copy link
Contributor Author

renovate bot commented Dec 6, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 6, 2023
@renovate renovate bot merged commit b3f857a into main Dec 6, 2023
35 checks passed
@renovate renovate bot deleted the renovate/netlify-packages branch December 6, 2023 17:15
@Skn0tt
Copy link
Contributor

Skn0tt commented Dec 7, 2023

good work @lukasholzer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants